Horace He
Horace He
Currently, there are no plans. Do you have a particular use case for this?
Hi, thanks for the PR :) Most of the work on this tracer is now going on here: https://github.com/pytorch/pytorch/blob/master/torch/fx/experimental/proxy_tensor.py However, about the specific proposal in this PR.... I don't know...
I suspect that would be more likely, yeah.
cc: @eellison (this issue could also go on the TorchDynamo repo)
Note: I've currently not bothered to land this PR, as Torchscript seems to keep all of the input activations alive. We've verified that this reduces memory usage as expected if...
I think there are still some tests failing. For example, I don't believe `push_back` is a method on python lists :) https://github.com/pytorch/functorch/pull/675/files#diff-8e71d16136c7deeb8104d8d5bb0dd794c208f38856f9ced3448ab02f3e34c43aR522 To run the tests, run ``` pytest test/test_ops.py::TestDecompositionOpInfoCUDA...
@Shukla-Gaurav Do you mean that it always passes, regardless of whether your decomposition is correct? Or are you asking why the decompositions are passing even though the CI fails? If...
@Shukla-Gaurav btw, is this mergeable?
@Shukla-Gaurav Yes, can you re-open this PR on upstream PyTorch?
Seems like a composite compliance issue @zou3519 I thought that functionalization should be able to fix this, but seems to segfault. Any ideas @bdhirsh?