ChiliPhotoPicker icon indicating copy to clipboard operation
ChiliPhotoPicker copied to clipboard

Videos support

Open rafsanjani opened this issue 4 years ago • 3 comments

I've been using this very useful library a lot so I decided to add the support for choosing and taking videos. I have also upgraded all dependencies to latest versions and made appropriate syntax corrections where necessary.

This can be activated by passing an optional parameter pickerType to the newInstance method. By default only photos can be selected.

Videos Selection

MediaPickerFragment.newInstance(
        multiple = true,
        allowCamera = true,
        pickerType = MediaPickerFragment.PickerType.VIDEO, //optional, default is photo
        maxSelection = 5,
        theme = R.style.ChiliPhotoPicker_Dark
    ).show(supportFragmentManager, "picker")
    

Mixture of Videos and Photos

MediaPickerFragment.newInstance(
            multiple = true,
            allowCamera = true,
            pickerType = MediaPickerFragment.PickerType.ANY,//optional, default is photo
            maxSelection = 5,
            theme = R.style.ChiliPhotoPicker_Dark
        ).show(supportFragmentManager, "picker")
    

Almost every core class has been renamed (apparently we can't keep the photo prefixes because there is video suppport now) so this enhancement causes a breaking change. These are the classes that have changed.

Old name New Name
SelectablePhoto SelectableMedia
PhotoPickerFragment MediaPickerFragment
PhotoPickerAdapter MediaPickerAdapter

Consumers of this class only need to worry about renaming PhotoPickerFragment to MediaPickerFragment and the callback from PhotoPickerFragment.Callback to MediaPickerFragment.Callback

Everything else remains the same.

rafsanjani avatar Mar 20 '20 12:03 rafsanjani

Thanks for your contribution. Would be nice to have option for picking both media types

APetjko avatar Mar 20 '20 12:03 APetjko

@APetjko The thought actually crossed my mind. I will see if I can work on it over the weekend.

rafsanjani avatar Mar 20 '20 12:03 rafsanjani

@APetjko Self Isolation in the UK has given me some time to add support for choosing both videos and photos. You might want to check it out.

rafsanjani avatar Mar 24 '20 17:03 rafsanjani