RSocrata icon indicating copy to clipboard operation
RSocrata copied to clipboard

Change unit test

Open tomschenkjr opened this issue 8 years ago • 6 comments

We've been using @CityofBoston open data portal to run a unit test to ensure the package is correctly importing data with missing dates (from #27). However, in recent tests, it appears that data set is no longer available--at least, need to login to see it.

The original data set was the Mayor's 24-hour hotline dataset. However, Boston is moving to a new data portal and is likely migrating content. @therriault was the above data set replaced by the same data from the new portal?

Regardless, for us, Boston is moving to a whole new portal that is not Socrata based. We will need to replace the test. We need to find or create (see #45) a new data set with a missing date to test this functionality.

(Discovered this while working on #136)

tomschenkjr avatar Mar 28 '17 20:03 tomschenkjr

Turns out this issue was related to a technical glitch for Boston and is working again. Not a pressing issue but their portal will be retired soon so keeping it open for now.

@therriault - is this data set being immediately retired with the new data portal on the 6th?

tomschenkjr avatar Apr 05 '17 16:04 tomschenkjr

We moved the dataset to the new portal: https://data.boston.gov/dataset/mayors-24-hour-hotline. But the old site will be up for a few months still.

therriault avatar Apr 25 '17 18:04 therriault

@chrismetcalf - Boston has redirected their old portal data to their new portal, which broke a unit test for a specific case where the first entry is a missing date.

Would it be acceptable to upload a similar data set to soda.demo.socrata.com so we can keep the unit test? I hesitate to put it on Chicago's because it mixes a technical, not-otherwise-useful data with official city data.

tomschenkjr avatar Dec 04 '17 15:12 tomschenkjr

Right now, have staged a temporary fix that just ignores the unit test on branch hotfix1.7.4

tomschenkjr avatar Dec 11 '17 20:12 tomschenkjr

@tomschenkjr I relayed a recommendation to you through our support team, but I thought I'd post it here too:

How I handle authenticated integration tests for the other libraries is to pull in the email/password details from an environment variable I can set before running the test. Then I create a continuous integration setup in Travis CI that automatically tests pushes to GitHub, and I can set hidden environment variables for a very-limited test user in their interface so Travis can run the tests. Ex: https://travis-ci.org/socrata/soda-php

Then you can set the environment variables locally if you want to test locally, and you can rely on TravisCI to make sure you don't merge bad changes from others.

chrismetcalf avatar Dec 12 '17 00:12 chrismetcalf

Actually, will re-open this since we only have a temporary fix in place.

tomschenkjr avatar Dec 12 '17 20:12 tomschenkjr