clvm icon indicating copy to clipboard operation
clvm copied to clipboard

Added py.typed to export hints for mypy, fixup hints

Open Quexington opened this issue 4 years ago • 6 comments

Quexington avatar Aug 10 '21 21:08 Quexington

This PR is technically good to go in terms of this repository, the problem is that since the types will be detectable now, the chia-blockchain repository is going to face a bunch of linting errors. Best hold off until there is a corresponding PR to fix those as well.

Quexington avatar Aug 10 '21 21:08 Quexington

Unfixed errors are being ignored in https://github.com/Chia-Network/chia-blockchain/pull/9371.

altendky avatar Nov 24 '21 16:11 altendky

We should merge this imo @Quexington, dealing with the issues will be a good thing

mariano54 avatar Aug 16 '22 12:08 mariano54

I had done some more hinting work, but I don't really recall the form and now it has become disconnected seemingly. https://github.com/Chia-Network/clvm/pull/107 Maybe next week I could look back around this stuff? Maybe I'm being overly optimistic about that? :|

altendky avatar Aug 17 '22 15:08 altendky

I agree @mariano54 it just would have required a rather large PR into chia-blockchain (and certainly a larger one now). One of the biggest fixes will be that SerializedProgram and Program will actually be distinct and there's a TON of places where we pass a Program where it's expecting the latter IIRC.

Quexington avatar Aug 17 '22 23:08 Quexington

I think we should at least have mypy running here? I'm taking a quick peek at catching up my other effort, now in https://github.com/Chia-Network/clvm/pull/125. It might also be worth waiting until atari checkpoints to bulk edit main in blockchain in response to this.

altendky avatar Aug 18 '22 01:08 altendky