chiapos
chiapos copied to clipboard
Allow offline builds of chiapos with local repos
Pull Request Test Coverage Report for Build 10494997837
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 79.051%
| Totals | |
|---|---|
| Change from base Build 10410315404: | 0.0% |
| Covered Lines: | 3498 |
| Relevant Lines: | 4425 |
💛 - Coveralls
Agreeing with Arvid that the build process should work the same whether building locally or on CI. I think we're both missing something about the motivation here?
The discussion happened on keybase yesterday. The summary is:
- rust creates don't allow the build step to pull things from the internet. I suspect the main reason is to ensure builds are deterministic.
- our cmake file uses FetchContent to download dependencies, which means building the rust bindings fail (because internet access is blocked)
- We want a way to download and bundle the dependencies in the crate separate from the building step
'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'