chia_rs icon indicating copy to clipboard operation
chia_rs copied to clipboard

Add needed items for sdist

Open emlowe opened this issue 1 year ago • 2 comments

Add in some missing bits in wheel/Cargo.toml and some hacks around missing parts in the tar archive

Main items are: needing to add in chia-client and chia-ssl to wheel/Cargo.toml needing to remove the ../LICENSE from wheel/Cargo.toml - this resulted in the tar not having the LICENSE file but also pip expecting it, so I just removed it for now. I noticed the tar was missing the src directory, so I had to manually add in the src directory to the tar archive.

This does make a tar.gz that does build on my riscv machine and also my mac.

emlowe avatar Oct 09 '24 21:10 emlowe

Pull Request Test Coverage Report for Build 11263879338

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.638%

Totals Coverage Status
Change from base Build 11262793680: 0.0%
Covered Lines: 12708
Relevant Lines: 15194

💛 - Coveralls

coveralls-official[bot] avatar Oct 09 '24 22:10 coveralls-official[bot]

When maturin builds the sdist, it puts in the tar the Cargo.toml from the root workspace and not from the wheel directory. They are listed in the root Cargo as deps and default features.

emlowe avatar Oct 10 '24 14:10 emlowe

I see. thanks for the explanation.

arvidn avatar Oct 10 '24 22:10 arvidn