chia_rs icon indicating copy to clipboard operation
chia_rs copied to clipboard

Add Prettier to the CI workflows

Open Rigidity opened this issue 1 year ago • 5 comments

Rigidity avatar May 07 '24 14:05 Rigidity

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, unsafe 0 8.39 MB prettier-bot

View full report↗︎

socket-security[bot] avatar May 07 '24 14:05 socket-security[bot]

Pull Request Test Coverage Report for Build 8986872099

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 88 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.6%) to 84.218%

Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/fullblock.rs 1 0.0%
crates/chia-protocol/src/end_of_sub_slot_bundle.rs 1 0.0%
crates/chia-protocol/src/unfinished_block.rs 1 0.0%
crates/chia-protocol/src/sub_epoch_summary.rs 1 0.0%
crates/chia-protocol/src/coin_state.rs 1 0.0%
crates/chia-protocol/src/peer_info.rs 1 0.0%
crates/chia-protocol/src/header_block.rs 1 0.0%
crates/chia-protocol/src/unfinished_header_block.rs 1 0.0%
crates/chia-protocol/src/proof_of_space.rs 1 0.0%
crates/chia-protocol/src/pool_target.rs 1 0.0%
<!-- Total: 88
Totals Coverage Status
Change from base Build 8908521951: -0.6%
Covered Lines: 11735
Relevant Lines: 13934

💛 - Coveralls

coveralls-official[bot] avatar May 07 '24 14:05 coveralls-official[bot]

when I run pre-commit run --all in this branch, I get this:

[warn] README.html
[warn] wasm/pkg/chia_wasm_bg.js
[warn] wasm/pkg/chia_wasm.d.ts
[warn] wasm/pkg/chia_wasm.js
[warn] Code style issues found in 4 files. Run Prettier to fix.

the output gets messed up as there appears to be some carriage returns and newlines in there. It seems the command fails though.

arvidn avatar May 08 '24 22:05 arvidn

$ echo $?
1

arvidn avatar May 08 '24 22:05 arvidn

when I run pre-commit run --all in this branch, I get this:

[warn] README.html
[warn] wasm/pkg/chia_wasm_bg.js
[warn] wasm/pkg/chia_wasm.d.ts
[warn] wasm/pkg/chia_wasm.js
[warn] Code style issues found in 4 files. Run Prettier to fix.

the output gets messed up as there appears to be some carriage returns and newlines in there. It seems the command fails though.

It passes for me, perhaps it's an auto-CRLF issue?

Rigidity avatar May 09 '24 02:05 Rigidity