chia_rs icon indicating copy to clipboard operation
chia_rs copied to clipboard
verified publisher icon Chia-Network

Fix ROM deserializer bug.

Open richardkiss opened this issue 2 years ago • 4 comments

richardkiss avatar Jul 18 '23 23:07 richardkiss

Pull Request Test Coverage Report for Build 5593441199

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.734%
Totals Coverage Status
Change from base Build 5545909516: 0.0%
Covered Lines: 7339
Relevant Lines: 7914
💛 - Coveralls

coveralls-official[bot] avatar Jul 19 '23 00:07 coveralls-official[bot]

Is this still an issue or can this be closed?

Rigidity avatar Aug 21 '24 05:08 Rigidity

This change is a hard fork and we don't (yet) use the deserializer in our generators. So I think it's fair to say that at best this may want to be considered for a future hard fork. But I don't think there's a champion for it.

arvidn avatar Aug 21 '24 05:08 arvidn

It's more just an embarrassment of legacy, but I doubt this code would ever be used even if it were fixed. I'd actually prefer a hard fork that removes it.

richardkiss avatar Aug 21 '24 20:08 richardkiss