chia-blockchain icon indicating copy to clipboard operation
chia-blockchain copied to clipboard

Published 20 hours ago • verified publisher icon Chia-Network

Add additional partial headers

Open felixbrucker opened this issue 5 months ago • 7 comments

Purpose:

Expose farmer peer id, full harvester version, harvester capacity (raw/effective) and plot count when submitting a partial.

Current Behavior:

Currently only the full farmer version and harvester peer id are exposed

New Behavior:

Farmer and harvester peer id and full version, as well as harvester capacity and plot count are exposed.

Testing Notes:

Limitation: capacity and plot count are not scoped by plotnft yet, as those are not tracked separately right now in plot_sync_receivers. The current lookups are fast as its just a direct variable access, scoping per launcher id/contract address would require additional compute resources without a refactor of how plot_sync_receivers works right now.

  • Depends on https://github.com/Chia-Network/chia-blockchain/pull/15679

felixbrucker avatar Mar 27 '24 04:03 felixbrucker

Interestingly, RFC 6648 (https://www.rfc-editor.org/rfc/rfc6648) deprecates using X- as the beginning nomenclature for new parameters. Perhaps chia should be in the name somewhere - maybe chia-farmer-peer-id

emlowe avatar Mar 28 '24 15:03 emlowe

Some Internal discussion indicates that some of these would be contentious to send by default - I suggest creating a new CHIP to discuss those and they may need to be optional to send

The harvester version itself is likely not controversial - but some of the others eliciting some internal feedback

emlowe avatar Mar 28 '24 16:03 emlowe

some of these would be contentious to send by default - I suggest creating a new CHIP to discuss those and they may need to be optional to send

which ones exactly?

felixbrucker avatar Mar 28 '24 17:03 felixbrucker

some of these would be contentious to send by default - I suggest creating a new CHIP to discuss those and they may need to be optional to send

which ones exactly?

Farmer peer ID. This might work well as an informational CHIP if there are other clients that could use it. I'm not familiar enough with the pooling protocols to say for sure, though.

danieljperry avatar Mar 28 '24 22:03 danieljperry

I don't see how that is contentious in any way, but sure i can create a chip for it

felixbrucker avatar Mar 28 '24 23:03 felixbrucker

The CHIP PR is available here: https://github.com/Chia-Network/chips/pull/114

felixbrucker avatar Mar 29 '24 10:03 felixbrucker