chia-blockchain
chia-blockchain copied to clipboard
Chia-Network
New peak eos edge case
Purpose:
when choosing between two peaks with the same height chose the chain with less iterations even if peaks are on different sub_slots
Current Behavior:
we will chose the peak that was discovered first
New Behavior:
prefer the chain with lower iterations
Testing Notes:
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
Don't we want the chain with more iterations or is the inference that less iterations in the same epoch implies a better proof of space?
Don't we want the chain with more iterations or is the inference that less iterations in the same epoch implies a better proof of space?
this avoids some possible orphaning strategies. the motivation is that the lower iterations chain might be heavier at the same iterations if we keep on it and wait for the next block, this only happens when the weight of the two chains is the same, otherwise we still always prefer the heavier chain
| File | Coverage | Missing Lines |
|---|---|---|
chia/full_node/full_node.py |
87.5% | lines 2184-2185 |
| Total | Missing | Coverage |
|---|---|---|
| 17 lines | 2 lines | 88% |
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.