chia-blockchain icon indicating copy to clipboard operation
chia-blockchain copied to clipboard

Warn users before combining many coins with no fee

Open hoffmang9 opened this issue 1 year ago • 4 comments

Purpose:

Current behavior is that if a user runs chia wallet coins combine without specifying a fee, 0 will be used and all coins in the wallet can be locked in the spend bundle. This can be RBF'ed but much better to make sure the user really wants no fee on their combine.

Current Behavior:

In default options - can create a large spend bundle with no fee.

New Behavior:

User has to confirm they mean to use no fee

Testing Notes:

Confirmed working on mainnet

hoffmang9 avatar Feb 15 '24 21:02 hoffmang9

File Coverage Missing Lines
chia/cmds/coin_funcs.py 33.3% lines 186-187
Total Missing Coverage
3 lines 2 lines 33%

github-actions[bot] avatar Feb 16 '24 13:02 github-actions[bot]

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

github-actions[bot] avatar May 12 '24 11:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 26 '24 16:06 github-actions[bot]

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

github-actions[bot] avatar Aug 12 '24 11:08 github-actions[bot]