chia-blockchain
chia-blockchain copied to clipboard
Chia-Network
DL multiple batch updates.
Allows to split a batch updates into multiple commands, by setting publish_on_chain=False inside the batch_update. If using the option, a new batch update will be continued on top of the previous one, which is saved only locally. It's possible to discard the unpublished batch by doing clear_pending_roots, or to publish it by doing publish_pending_root. Internally, this implements the new root status PENDING_BATCH, which works similarly to the previous PENDING root, except it allows batch_update to build on top of it and it's never published on chain - when it gets published, it'll change to the PENDING status.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
Now that this is all using publish, I'm wondering if submit isn't more consistent terminology with other parts of chia - for example, Transaction submitted to nodes
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
I misunderstood and thought the pending batch -> committed status was a permanent thing rather than an intermediate change that would get reverted. My above review has several comments that I think end up related to this so I will go back through and review them now.
Pull Request Test Coverage Report for Build 7998480313
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- -6 of 237 (97.47%) changed or added relevant lines in 9 files are covered.
- 984 unchanged lines in 40 files lost coverage.
- Overall coverage increased (+0.05%) to 90.979%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| chia/data_layer/data_layer.py | 18 | 19 | 94.74% |
| chia/data_layer/data_store.py | 16 | 18 | 88.89% |
| chia/rpc/data_layer_rpc_api.py | 12 | 15 | 80.0% |
| <!-- | Total: | 231 | 237 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| chia/consensus/block_record.py | 1 | 95.24% |
| chia/daemon/server.py | 1 | 88.56% |
| chia/data_layer/dl_wallet_store.py | 1 | 95.74% |
| chia/data_layer/download_data.py | 1 | 71.04% |
| chia/introducer/introducer.py | 1 | 78.26% |
| chia/rpc/data_layer_rpc_api.py | 1 | 83.05% |
| chia/util/json_util.py | 1 | 88.46% |
| tests/core/full_node/stores/test_block_store.py | 1 | 99.19% |
| tests/core/util/test_file_keyring_synchronization.py | 1 | 97.1% |
| tests/fee_estimation/test_fee_estimation_unit_tests.py | 1 | 99.06% |
| <!-- | Total: | 984 |
| Totals | |
|---|---|
| Change from base Build 7916358366: | 0.05% |
| Covered Lines: | 97240 |
| Relevant Lines: | 106853 |
💛 - Coveralls
![coveralls-official[bot] avatar](https://avatars.githubusercontent.com/in/296425?v=4 "Published by a pub.dev verified publisher"){kind=small}
| File | Coverage | Missing Lines |
|---|---|---|
chia/data_layer/data_layer.py |
94.7% | lines 320 |
chia/data_layer/data_store.py |
88.9% | lines 1363, 1368 |
chia/rpc/data_layer_rpc_api.py |
80.0% | lines 251, 255, 294 |
| Total | Missing | Coverage |
|---|---|---|
| 237 lines | 6 lines | 97% |
Removing coverage diff: only exceptions thrown in case of bugs are failing now