chia-blockchain icon indicating copy to clipboard operation
chia-blockchain copied to clipboard

Ms.peer required

Open mariano54 opened this issue 2 years ago • 2 comments

These three methods in wallet_node: fetch_puzzle_solution, get_coin_state, and fetch_children, are all called during sync, by the different wallets (and WSM). If any of them fail, the whole sync will stop. This is a problem, especially if we are connected to a peer that is not synced to the chain (for example our local node).

This fixes it, by forcing the sync target peer to be passed in. This peer must be synced up to the chain, so they will respond with the correct data. If something goes wrong, sync stops, and it can resume again with another peer.

This seems like a big change but it's not. It's just passing in an additional peer argument everywhere.

mariano54 avatar Aug 10 '22 15:08 mariano54

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 11 '22 05:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 11 '22 05:08 github-actions[bot]

This one should be merged to main after ms.wlt_node_unsynced @wallentx

mariano54 avatar Aug 11 '22 15:08 mariano54