chia-blockchain icon indicating copy to clipboard operation
chia-blockchain copied to clipboard

Published 20 hours ago • verified publisher icon Chia-Network

util: Implement key name support for `FileKeyring` and `KeyringWrapper`

Open xdustinface opened this issue 2 years ago • 1 comments

This PR implements key name support for the FileKeyring and KeyringWrapper classes. The logic to restrict adding names for key's that don't exist in the FileKeyring will come to Keychain in a follow up PR since the FileKeyring in its current version doesn't know about the actual data stored in it. This can be changed later after the legacy keyring support was removed.

There will be follow up PRs for:

  • Keychain + KeychainServer
  • CLI
  • RPC

Based on:

  • #12669

xdustinface avatar Aug 09 '22 00:08 xdustinface

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 10 '22 08:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 23 '22 10:08 github-actions[bot]

Looks good. Just a few things to look at.

Thanks, addressed the suggestions.

xdustinface avatar Aug 24 '22 08:08 xdustinface

This pull request introduces 1 alert when merging f126660655451c42c06ece4994a9cd09e2ec385a into 30be830ff35f58523603d4276aca65b4c99dab47 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Aug 24 '22 08:08 lgtm-com[bot]

This pull request introduces 1 alert when merging 6be6dccb3e202aea810dbabb4e425bf6a74fa0e8 into 30be830ff35f58523603d4276aca65b4c99dab47 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Aug 24 '22 09:08 lgtm-com[bot]

This needs new CI changes for OSX in order for the build to work. Merging past this

wallentx avatar Aug 26 '22 00:08 wallentx