chia-blockchain
chia-blockchain copied to clipboard
Change all commands to use one client generator function & Add chia peer command
Copy of #12532 due to git issues
there is no diff between this branch and old branch + merge
old branch viewable at jn.cmds-refactor-old
, if you merge this please also delete that branch
This pull request introduces 39 alerts when merging ef271368f891f37cb116190c7261e24d98a42894 into c9bebc6c405e6896e9ec3b34cdedc2bb1739c748 - view on LGTM.com
new alerts:
- 39 for Module-level cyclic import
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request introduces 37 alerts when merging 8ff42336c8e00f8ec816422e7e498b173e3fb01c into 5080daabad0b8abd582de2840a6d81247bc60e3c - view on LGTM.com
new alerts:
- 37 for Module-level cyclic import
This pull request introduces 37 alerts when merging 7d639cac1334e71a4cde44d4d0ab1b78250fa83a into d9b271dbfa370120527a7aaeca767974145b91bf - view on LGTM.com
new alerts:
- 37 for Module-level cyclic import
@mariano54 I'm not sure that the LGTM results are valid, since a glance at all the alerts that it has produced for us shows the same cyclic import errors for pretty much all of our code. If CodeQL is the suggested replacement, the results of the CodeQL scan didn't return any issues https://github.com/Chia-Network/chia-blockchain/pull/12778/checks?check_run_id=7846986494
LGTM.com will be shut down in December 2022 — we recommend that you use GitHub code scanning instead. Read more in our blog post on the GitHub blog.
We either need to scan this with github code scanning. Or snyk. I agree that the LGTM stuff appears to be a false positive, and this tool is going away anyway. IPS is going to work to sunset this tool in the next month or so.