chia-blockchain icon indicating copy to clipboard operation
chia-blockchain copied to clipboard

Change 'series' to 'edition'

Open DrakoPensulo opened this issue 2 years ago • 3 comments

Change 'series_total' to 'edition_count' and 'series_number' to 'edition_number'

Make the changes consistent in the whole code.

DrakoPensulo avatar Aug 03 '22 05:08 DrakoPensulo

The file tests\wallet\nft_wallet\test_nft_wallet.py needs to be updated for more checks to be successful.

DrakoPensulo avatar Aug 03 '22 06:08 DrakoPensulo

This will require an update in the GUI

paninaro avatar Aug 05 '22 21:08 paninaro

Generally we try to maintain RPC backward compatibility. This change updates the RPC responses for nft_get_nfts and nft_get_info such that the series_total/series_number fields are replaced by their edition counterparts. Since other community developers may be impacted by this, we could either maintain backward compatibility by making the edition_* fields additive, or informing the community devs of this breaking change. I'll leave it to @trepca and @wjblanke to weigh in.

paninaro avatar Aug 05 '22 21:08 paninaro

Hi @DrakoPensulo, thanks for the PR. I believe we had already gotten this resolved in our release branch, whose changes haven't made it into main just yet, but will do so soon with one of our checkpoint PRs. https://github.com/Chia-Network/chia-blockchain/commit/af60a81c92cba51c650ad9a2fd2bf653efcbaf0e I just wanted to verify with you that our changes had addressed all of the areas that were the intent of your PR before closing this. Even if we do close this one, I'd be happy to give you a shout-out in our coming release for your contribution effort.

wallentx avatar Aug 15 '22 18:08 wallentx

Hi @wallentx . The changes in https://github.com/Chia-Network/chia-blockchain/commit/af60a81c92cba51c650ad9a2fd2bf653efcbaf0e look good to me. That is what I intended. Thank you.

DrakoPensulo avatar Aug 15 '22 19:08 DrakoPensulo