chia-blockchain icon indicating copy to clipboard operation
chia-blockchain copied to clipboard

Rework wallet new peak

Open almogdepaz opened this issue 2 years ago • 6 comments

separate trusted and non-trusted sync

separate non-trusted long and short sync

remove redundant code paths

validate peak header block - currently we request the block but dont validate the response this has unexpected results

don't request WP when not needed (untrusted short sync)

dont allow WP requests during secondary sync

almogdepaz avatar Jul 25 '22 15:07 almogdepaz

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 29 '22 22:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 07 '22 18:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 10 '22 11:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 10 '22 14:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 10 '22 20:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 10 '22 20:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 15 '22 08:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 24 '22 21:08 github-actions[bot]

I'll fix the conflicts

mariano54 avatar Aug 26 '22 21:08 mariano54

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

github-actions[bot] avatar Oct 11 '22 11:10 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Oct 24 '22 09:10 github-actions[bot]

@arvidn @trepca i revived the pr, conflicts resolved

almogdepaz avatar Oct 24 '22 15:10 almogdepaz

@almogdepaz this is great, thanks. I just have a few comments

fixed, thanks

almogdepaz avatar Oct 30 '22 10:10 almogdepaz