bls-signatures icon indicating copy to clipboard operation
bls-signatures copied to clipboard

Published 20 hours ago • verified publisher icon Chia-Network

Update jsbindings.cpp

Open BubbleTrouble14 opened this issue 11 months ago • 1 comments

Changed in the correct place now.

BubbleTrouble14 avatar Mar 24 '24 15:03 BubbleTrouble14

Pull Request Test Coverage Report for Build 8410371840

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.649%
Totals Coverage Status
Change from base Build 8345515027: 0.0%
Covered Lines: 1645
Relevant Lines: 1738
💛 - Coveralls

coveralls-official[bot] avatar Mar 24 '24 16:03 coveralls-official[bot]

This can't be correct - you change the G2Element to use the G1Element generator?

emlowe avatar May 13 '24 22:05 emlowe

This can't be correct - you change the G2Element to use the G1Element generator?

Yes indeed its wrong was supposed to update the G1Element to use the G1Element generator. But hadn‘t got round to then building it and doing it correctly. As when looking at the current implementation the g1 generator returns the G2Element in the types which i assume is incorrect ?

BubbleTrouble14 avatar May 14 '24 03:05 BubbleTrouble14

Location in the generated types as seen here.

BubbleTrouble14 avatar May 14 '24 03:05 BubbleTrouble14