bls-signatures
bls-signatures copied to clipboard
Chia-Network
take span instead of std::vector to simplify interface
modernize the interface a bit to take span rather than std::vector. For now, use our own span type, but this could use GSL or std::span in the future. The main motivation for this is to allow passing ranges of values without having to first copy them into a std::vector. It also simplifies some of the functions that currently take both a span and a std::vector. By making span be implicitly constructed from a vector, we can remove one of the overloads.
I marked this as a draft for now. I think I may pivot this into just doing the span change (more pervasively) and make another attempt at avoiding copying all the messages in a separate PR
'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is this something that we still want to do? or should we close it? @xdustinface
I think there are a lot of opportunities to simplify the code by making changes like this, and embracing a span type. Championing these changes are not very high on my priority list right now though.
OK, we can leave this open until someone decides to take this PR further, any help is welcome
'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'
'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'
@justinengland sorry for the delay. this message got lost in my inbox.
I could fix this patch up, but I'm not sure it's worth the effort. I'm hoping we can move away from blspy to python bindings on top of chia-bls (rust library) once we have transitioned it to use BLST. That's some time out, but this PR is also really just a cleanup and minor performance fix.
'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'
