drupal-code-generator icon indicating copy to clipboard operation
drupal-code-generator copied to clipboard

Published 20 hours ago • verified publisher icon Chi-teck

Find a new maintainer

Open Chi-teck opened this issue 10 months ago • 18 comments

Drupal Code Generator turned 10 years, marking a significant milestone. Unfortunately, I don't have enough time to properly maintain it these days, as I need to focus on other projects, both commercial and open source.

Requirements for the new maintainer:

  1. Extensive experience in Drupal development.
  2. Previous contributions to this project (desirable).
  3. Willingness to dedicate significant time to its maintenance.

Chi-teck avatar Jan 07 '25 17:01 Chi-teck

Wow, its been 10 great years. Drush users have benefitted so much from DCG. Thanks so much for your service.

weitzman avatar Jan 07 '25 17:01 weitzman

That's awesome and sad at the same time. If I can be of any help, let me know!

PierrePaul avatar Jan 11 '25 01:01 PierrePaul

I can put in a few hours every week , is that enough? I haven't contributed to this before but this is so useful.

chx avatar Mar 07 '25 20:03 chx

Hi @chx. You were just granted access to this project. Feel free to commit whatever you think is appropriate.

Thank you!

Chi-teck avatar Mar 10 '25 03:03 Chi-teck

Thanks @chx and @Chi-teck. What a fantastic outcome!

weitzman avatar Mar 10 '25 03:03 weitzman

Please do not close this, more help would be welcome.

Tests are not passing currently, partially due to https://github.com/Chi-teck/drupal-coder-extension/pull/7 which currently breaks lowest (and previously broke all) -- once 2.0 is out that'll be fixed. Also some phpstorm meta problems I do not understand yet, on it.

This is not related to fixing https://github.com/Chi-teck/drupal-code-generator/issues/199 which found not one but two core issues.

chx avatar Mar 10 '25 12:03 chx

Hi @Chi-teck , I’d be glad to join as a co-maintainer alongside @chx. I can contribute around 4 to 5 hours per week—would that be sufficient? I haven’t contributed to this project before, but I find it extremely useful and would love to get involved.

harivansh0 avatar Apr 25 '25 04:04 harivansh0

Hi @harivansh0, at this moment @chx is the maintainer of this project. So it's up to him adding new co-maintainers. I am thinking of transferring project ownership (need to figure out how to do it on GitHub).

For now you can contribute through PRs.

Thanks.

Chi-teck avatar Apr 25 '25 05:04 Chi-teck

Sure Hi @chx, I can contribute around 4 to 5 hours per week. Let me know if there's anything I can assist with. I also have a few feature requests and improvement suggestions that I’ll be submitting as new feature issues soon.

harivansh0 avatar Apr 25 '25 09:04 harivansh0

I would of course be glad to get more help, thanks. Let's chat on Slack.

chx avatar Apr 25 '25 15:04 chx

I am trying to get tests pass but they don't. It requires setting up Headless Chrome which I have no idea how, I always struggled setting this up, the documentation or rather the lack of it is simply atrocious. I deleted four JS tests until someone else figures it out. It's really frustrating.

chx avatar Jun 01 '25 00:06 chx

JS tests have high maintenance cost. They require complicated testing infrastructure and tend to fail more often then other. For instance Chrome 134 broke tests in all my projects (https://github.com/teamcapybara/capybara/issues/2800). The tests you have removed actually were not for JavaScript. There were for fields, widgets and formatters because Drupal heavily relies on ajax in Field UI. I could not find a way to deal with ajax forms in Drupal functional tests. BTW it was possible in Drupal 7 simlytests.

For the reference almost all tests in Date Point module are written using WebDriver even though the module itself does not have any JavaScript to test. That's not because I wanted to test Drupal ajax framework, that's just because there no other way to test forms for field widgets, formatters and Views plugins.

Chi-teck avatar Jun 01 '25 02:06 Chi-teck

The only JS file generated by DCG is fairly trivial and doesn’t require extensive testing. There was a generator for CKEditor plugin that produced a bunch of relatively complex JS files. But it was removed to reduce maintenance costs.

Chi-teck avatar Jun 01 '25 03:06 Chi-teck

How did these work in the first place? Like, how did chrome got installed? Does it use Chromedriver ? I haven't seen either being installed.

chx avatar Jun 01 '25 03:06 chx

WebDriver tests never worked on GitHub CI because they are slow and tend to fail more often then other. Though I suppose it is possible to configure GA to run them. When WebDriver host is not reachable PhpUnit just marks the tests as skipped. I ran these tests occasionally on my localhost with local Google Chrome instance.

Chi-teck avatar Jun 01 '25 04:06 Chi-teck

Well, unless I am mistaken https://github.com/Chi-teck/drupal-code-generator/actions/runs/15368796852/job/43245085590 and more has failed because of this.

chx avatar Jun 01 '25 13:06 chx

Something might be changed in the latest PhpUnit versions. I would just drop these tests or exclude explicitly.

Chi-teck avatar Jun 01 '25 14:06 Chi-teck

Thanks, that makes much more sense than it magically working and breaking. I deleted them for the time being, git will have them if we can resurrect them and opened an issue for someone else to get this working.

I got the rest passing yesterday, just tagged 4.2.0 and will forge on.

chx avatar Jun 01 '25 14:06 chx