nodejs-whisper icon indicating copy to clipboard operation
nodejs-whisper copied to clipboard

Too much is being logged

Open binarykitchen opened this issue 1 year ago • 4 comments

Verbose flag is set to false, yet too much is logged, like that:

[dev:server] 
[dev:server] stderr--- whisper_init_from_file_with_params_no_state: loading model from './models/ggml-base.bin'
[dev:server] whisper_model_load: loading model
[dev:server] whisper_model_load: n_vocab       = 51865
[dev:server] whisper_model_load: n_audio_ctx   = 1500
[dev:server] whisper_model_load: n_audio_state = 512
[dev:server] whisper_model_load: n_audio_head  = 8
[dev:server] whisper_model_load: n_audio_layer = 6
[dev:server] whisper_model_load: n_text_ctx    = 448
[dev:server] whisper_model_load: n_text_state  = 512
[dev:server] whisper_model_load: n_text_head   = 8
[dev:server] whisper_model_load: n_text_layer  = 6
[dev:server] whisper_model_load: n_mels        = 80
[dev:server] whisper_model_load: ftype         = 1
[dev:server] whisper_model_load: qntvr         = 0
[dev:server] whisper_model_load: type          = 2 (base)
[dev:server] whisper_model_load: adding 1608 extra tokens

Probably from Python/C dunno ...

binarykitchen avatar Sep 26 '24 08:09 binarykitchen

@ChetanXpro Can you introduce a new logger option?

binarykitchen avatar Sep 27 '24 05:09 binarykitchen

If you are too busy, would you accept a PR from me?

binarykitchen avatar Sep 29 '24 22:09 binarykitchen

@binarykitchen Yeah, I was a bit busy for some weeks. Maybe I will be free this week. Feel free to raise a PR, I am happy to merge that.

ChetanXpro avatar Oct 06 '24 09:10 ChetanXpro

Cool, new PR is up. I haven't tested it yet, please review carefully: https://github.com/ChetanXpro/nodejs-whisper/pull/118

binarykitchen avatar Oct 06 '24 10:10 binarykitchen

@ChetanXpro Done, tested. Please review and merge. And test yourself as well.

binarykitchen avatar Nov 22 '24 22:11 binarykitchen

Thanks @binarykitchen, I will review this soon.

ChetanXpro avatar Nov 26 '24 05:11 ChetanXpro

@ChetanXpro Please ...

binarykitchen avatar Dec 11 '24 08:12 binarykitchen

... two weeks !== soon

binarykitchen avatar Dec 11 '24 08:12 binarykitchen

@binarykitchen Thanks for the PR and sorry for the delayed response! This looks good to me and solves the logging issues. I'll merge this. I'm planning to make some follow-up improvements later to add log level support and control C++ logging (maybe we can do that just by passing verbose mode in cpp command).

ChetanXpro avatar Dec 13 '24 13:12 ChetanXpro

Yay, finally - Updating www.videomail.io now and testing ...

binarykitchen avatar Jan 06 '25 06:01 binarykitchen

No changelog @ChetanXpro ?

binarykitchen avatar Jan 06 '25 06:01 binarykitchen