ChestShop-3 icon indicating copy to clipboard operation
ChestShop-3 copied to clipboard

[#504] Implement SignName compatability with price restrictions

Open casptyche opened this issue 1 year ago • 4 comments

This is a proposed implementation for #504 Allow price limits for different item IDs.

The solution changes the PriceRestrictionModule to try to find a configured price restriction for the Item's ItemUtil#getSignName result. If none is found, it falls back to the item material as per the original implementation.

I've tested this briefly locally and it seems to work a treat with Slimefun4 items whilst maintaining compatibility with Vanilla items.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


casptyche avatar Jun 08 '24 13:06 casptyche

Updated MR to reflect it's ready for review and briefly tested locally

casptyche avatar Jun 08 '24 14:06 casptyche

My fault! I had removed the auto-format changes but it clearly auto-formatted again without me realizing right before I staged :')

Reverted import, version change & formatting changes.

Tested locally briefly to confirm still works (i.e. Player Head#2 in priceLimits.yml is enforced in game, and oak_sign in priceLimits.yml is enforced in game, confirming that 'other items' and 'materials' both still work)

casptyche avatar Jun 10 '24 20:06 casptyche

Is there any further action required on my end?

casptyche avatar Jun 18 '24 18:06 casptyche

Sorry, I simply didn't have time to look at this again yet.

Phoenix616 avatar Jun 18 '24 18:06 Phoenix616