ChestShop-3 icon indicating copy to clipboard operation
ChestShop-3 copied to clipboard

Cannot cancel shop creation using PreShopCreationEvent

Open azzztec opened this issue 4 years ago • 1 comments

What is happening?

In this case shop is created anyway: @EventHandler public void preShopCreation(PreShopCreationEvent e) { e.setCancelled(true); }

What did you expect to happen?

Shop should not be created.

Plugin Version

3.12

Plugin Config

default 3.12 config

Server Version

paper-1.17.1-295.jar

Server Log

default paper logs

What other plugins are you running?

only ChestShop

Agreements

  • [X] I have checked if there are already similar issues open.
  • [X] I am running the latest build available from https://ci.minebench.de/job/ChestShop-3/.
  • [X] I am running a version that has support for the type of issue.

Additional context

Maybe you have an actual discord channel where i can ask such questions? Because the link in spigot page have been expired.

azzztec avatar Oct 10 '21 06:10 azzztec

What do you expect cancelling to do? Because cancelling the event will indeed cancel the subsequent logic (e.g. the ShopCreatedEvent).

If you expect other things to happen you need to do that yourself (e.g. the event provides a method to change the sign's lines)

Phoenix616 avatar Oct 10 '21 11:10 Phoenix616