ChestShop-3
ChestShop-3 copied to clipboard
ChestShop-authors
"ChestShop" plugin incompatible with "The New Economy" plugin
Plugin Version
ChestShop-3.9.2-1.8.8.jar
Server Version
PaperSpigot 1.8.8
Server Log
It does not generate any errors and inside Minecraft says that I do not have enough money because it is skipping the plugin "The New Economy" and checking in EssentialsX. See this print: http://prntscr.com/p9jxiw
What other plugins are you running?
EssentialsX-2.17.1.15.jar The New Economy 0.1.1.8M4 Vault 1.7.2
What is happening?
The plugin "ChestShop-3.9.2-1.8.8" is not identifying the Economy of the plugin "The New Economy", only with "ChestShop-3.9.2-1.8.8" this happens, all my other plugins identify the economy plugin "The New Economy", but the plugin "ChestShop-3.9.2-1.8.8" he tries straight into the plugin economy "EssentialsX" See this print: http://prntscr.com/p9jxiw
What did you expect to happen?
"ChestShop-3.9.2-1.8.8" was supposed to use the "The New Economy" plugin economy just like all my other plugins use, just "ChestShop-3.9.2-1.8.8" doesn't work.
Additional context
I know the ChestShop plugin project for version 1.8 is not under development like the higher versions. But I really needed to fix this problem because my server is version 1.8 If you can help me, I'd appreciate it.
The 1.8.8 version supports all Vault compatible economy plugins. If "The New Economy" does not support that then it wont work with it.
If you want it to work then you will either need to use an updated ChestShop version which supports it, request Vault support from the author of your economy plugin or get someone to PR in support for it to the 1.8.8 version of ChestShop (which is only receiving security fixes anymore so it wont be getting new features unless they are provided in form of a PR)
The 1.8.8 version supports all Vault compatible economy plugins. If "The New Economy" does not support that then it wont work with it.
If you want it to work then you will either need to use an updated ChestShop version which supports it, request Vault support from the author of your economy plugin or get someone to PR in support for it to the 1.8.8 version of ChestShop (which is only receiving security fixes anymore so it wont be getting new features unless they are provided in form of a PR)
TNE supports Vault, this is either an issue with ChestShop grabbing the Vault registered economy too early, or Essentials not letting go of it. This can be verified by using any other shop plugin besides ChestShop 3 and it working with TNE.
ChestShop gets the Economy service provider when the plugin is enabled (in the onEnable method) the way it is suggested by the official VaultAPI docs. And because ChestShop softDepends on Vault it will always do that after Vault finished enabling so TNE needs to make sure the Economy service provider is registered before Vault is finished enabling, e.g. in the onLoad method. Also it needs to use a priority that is higher than Essentials' if the goal is to always be used before it. I don't know the code of that plugin so I'm not sure which one of these is actually the issue though.
ChestShop gets the Economy service provider when the plugin is enabled (in the onEnable method) the way it is suggested by the official VaultAPI docs. And because ChestShop softDepends on Vault it will always do that after Vault finished enabling so TNE needs to make sure the Economy service provider is registered before Vault is finished enabling, e.g. in the onLoad method. Also it needs to use a priority that is higher than Essentials' if the goal is to always be used before it. I don't know the code of that plugin so I'm not sure which one of these is actually the issue though.
This is the way TNE is registered, in fact TNE, Essentials and any other shop plugin work together as stated above.
Interesting. As far as I can tell right now that seems to indeed be done in a way that should work.
@Weark can you please provide the information missing from the issue template especially the server log?
It does not generate any errors. Here's me trying to buy an item from the store and showing that I have enough money: http://prntscr.com/p9mck6 See the log like this, just shows that I wrote the command /money: http://prntscr.com/p9mcnq
And as I said, all other plugins work perfectly with TNE, just ChestShop that can't identify it and go straight to EssentialsX economy.
The log file contains more information than just errors. Please provide at least the startup part of it as ChestShop logs some information there about which economy plugin it uses.
Ok, here is the log print when starting the server: http://prntscr.com/p9wzdq I hope you can fix the problem.
Well the full log would be easier (so that we have information about the load order) but judging by the fact that the plugin right after ChestShop uses TNE I have to assume that ChestShop also correctly selected that.
One note though: As you didn't include all plugins before it wasn't possible to tell that but MysqlPlayerDataBridge is a plugin that too intoracts with both your economy and ChestShop itself iirc. Make sure that your issue isn't caused by that one.
On Mon, 23 Sep 2019, 17:30 Weark, [email protected] wrote:
Ok, here is the log print when starting the server: http://prntscr.com/p9wzdq I hope you can fix the problem.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ChestShop-authors/ChestShop-3/issues/272?email_source=notifications&email_token=ABMAMTNC4WZUQJ3HJDVQKETQLDVI5A5CNFSM4IZE25PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7LOQ5I#issuecomment-534177909, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMAMTJ4BTRNFDNJPPT7XCDQLDVI5ANCNFSM4IZE25PA .
Even if I only turn on the server with ChestShop, TNE, EssentialsX and Vault the problem still remains.
How did you solve it?
On Tue, 24 Sep 2019, 05:55 Weark, [email protected] wrote:
We managed to solve the problem.
Thanks so much for the support.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ChestShop-authors/ChestShop-3/issues/272?email_source=notifications&email_token=ABMAMTPPKBXJ6U7TD3ZZCLTQLGMTZA5CNFSM4IZE25PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NB4RA#issuecomment-534388292, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMAMTNU6OOMYDABAOH2GMDQLGMTZANCNFSM4IZE25PA .
How did you solve it? … On Tue, 24 Sep 2019, 05:55 Weark, @.***> wrote: We managed to solve the problem. Thanks so much for the support. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#272?email_source=notifications&email_token=ABMAMTPPKBXJ6U7TD3ZZCLTQLGMTZA5CNFSM4IZE25PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NB4RA#issuecomment-534388292>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMAMTNU6OOMYDABAOH2GMDQLGMTZANCNFSM4IZE25PA .
Still not sure. He updated to the latest beta release of TNE and it works.