browser-extension icon indicating copy to clipboard operation
browser-extension copied to clipboard

Add "browser" environment variable to handle incompatibilities

Open emilgoldsmith opened this issue 8 years ago • 3 comments

As talked about in #79 and #52.

emilgoldsmith avatar Mar 18 '17 01:03 emilgoldsmith

Not browser. OS!

martynchamberlin avatar Mar 18 '17 01:03 martynchamberlin

Oh. Sorry. Got mixed up what we were talking about. Yes, for this, browser. :)

martynchamberlin avatar Mar 18 '17 01:03 martynchamberlin

Haha yeah. I guess we can only detect OS by javascript, not by distribution ;).

We can just add the environment variable in the webpack builds as we at build time know what the target browser is.

emilgoldsmith avatar Mar 18 '17 01:03 emilgoldsmith