Chengyu Zhu
Chengyu Zhu
@stevenhorsman @wainersm @fidencio @fitzthum @littlejawa In the PR, we used the variable `GUEST_PULL` to enable the guest pull feature by setting it to yes in the kata-agent. However, based on...
> Split this PR in 2 different PRs. > > One PR will be only related to changing the files under `.github/workflows`. There you add skeleton for the new items...
> I think I'm confused with the use case (and I strongly suspect I'm missing something): we need to chose one or the other at build time? No way to...
> Thanks for the great work. Though I am not quite familiar with kata, I am trying to give some constructive ideas upon the PR. Thanks for your review @Xynnn007....
> I skimmed through this PR and I have several suggestions, but let me start with the most basic one that will allow things to actually be tested. > >...
> Hi, @ChengyuZhu6 - Please can you rebase to resolve the conflict? Done.
@fidencio Thank you for your comments. I would like to explain why I chose to build the agent with PULL_TYPE instead of building one agent for both Kata and CoCo....
cc @fitzthum
>It's more work, but I do wonder if we should add all these agent options to https://github.com/kata-containers/kata-containers/blob/main/src/agent/README.md, or to a file like https://github.com/kata-containers/kata-containers/blob/main/src/runtime-rs/crates/shim/src/config.rs.in (but one with comments :) that we...
> > As you can see, the agent that supports guest pull will download and compile about two hundred more dependencies, which results in the agent that supports guest pull...