Cheney Wang

Results 131 comments of Cheney Wang

If we remove the `d` suffix from below codes: https://github.com/eProsima/Fast-DDS/blob/d3ca40cbce231c4bdb4fc88a4b3911afaaae4f6f/tools/fds/CMakeLists.txt#L72 `set_target_properties(${PROJECT_NAME} PROPERTIES DEBUG_POSTFIX d-${PROJECT_VERSION})` allowing this port to generate tool files with the same name in both debug and release...

Yes. @tsondergaard Could you please remove below records from the vcpkg\scripts\ci.baseline.txt file(line 964~970)? Thank you! ``` # Missing prerequisites for CI success # Fail due to outdated protoc headers. #...

Please see [#30604](https://github.com/microsoft/vcpkg/issues/30604) for how to report an issue.

I can't reproduce this issue in my side with the latest vcpkg. ![image](https://github.com/microsoft/vcpkg/assets/38240633/0d4a3b8b-a022-44d0-92d9-8bba0f645a3d)

Please use [vcpkg_install_copyright](https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_install_copyright.md#vcpkg_install_copyright) instead of `file(INSTALL ...)` for copyright file. Other cl failures can be found in the log here: https://dev.azure.com/vcpkg/public/_build/results?buildId=81584&view=artifacts&pathAsName=false&type=publishedArtifacts

I tried to test the usage on Linux machine with following CMakelist.txt: ``` cmake_minimum_required(VERSION 3.10) project(test-project) add_executable(main main.cpp) find_package(libgourou CONFIG REQUIRED) target_link_libraries(main PRIVATE gourou gourou_utils gourou_include gourou_compiler_flags) ``` and I...

@SamuelMarks Could you please apply my suggestions?

I added some comments in `vcpkg.json` file before, about the `"version"` and `"supports"`, could you please take a look?

@SamuelMarks Are you still working on this PR?

https://github.com/microsoft/vcpkg/pull/28037/files#r1034336129 https://github.com/microsoft/vcpkg/pull/28037/files#r1034336172 https://github.com/microsoft/vcpkg/pull/28037/files#r1034349135 https://github.com/microsoft/vcpkg/pull/28037/files#r1034336205 https://github.com/microsoft/vcpkg/pull/28037/files#r1034336223 https://github.com/microsoft/vcpkg/pull/28037/files#r1034349662 Could you please apply above suggestions? Thank you!