Jose M. Valera Reales

Results 87 comments of Jose M. Valera Reales

Thanks, @nosrio! I would consider this a `feature` rather than a `bug` as it's not "broken", but slow. Feel free to try to suggest an improvement (PRs welcome!), otherwise we...

@staabm data providers are implemented here: https://github.com/TypedDevs/bashunit/blob/main/src%2Frunner.sh#L68 I think the issue is that we are loading and reading the test file to load the provider data function here: https://github.com/TypedDevs/bashunit/blob/main/src/helpers.sh#L124 Do...

@staabm I thought that at the beginning, but debugging you can see that I am asining only data_provider_function(therefore using that grep to the script file) only once 🤔 --- This...

One idea worth speeding up the current implementation is to avoid doing the grep at all (to look for the function name). Instead, use the same test name by convention...

I don't see much difference. It is not worth it (at least for now, although the change is relatively easy to implement). After much thought, @nosrio @staabm, I concluded that...

I will take over preparing an example for this repo. It might take a few days, because I want to focus first on fixing a couple features and one bug...

Closed in favor of https://github.com/TypedDevs/bashunit/pull/430

I just found out that we talked about this already https://github.com/phel-lang/phel-lang/pull/603 and we decided to dont do this. However, now that we have the str library ns, I will create...

I will make this as a draft, as I need some more time to double check one error I am facing on the website when using this code on `composer...

Closed in favor of https://github.com/phel-lang/phel-lang/pull/833