Tomasz Cielecki

Results 216 comments of Tomasz Cielecki

I've changed the implementation, with inspiration from https://codereview.stackexchange.com/a/129600, to properly generate a RFC 2368 mailto URL. So previously there were several issues. - `To`, `CC`, `BCC` where all URL escaped,...

Also find it a bit weird why [`MailMessage`](https://learn.microsoft.com/en-us/dotnet/api/system.net.mail.mailmessage?view=net-7.0) is not used instead of rolling your own? Any particular reason for this?

> @Cheesebaron just an FYI we didn't forget about this one! Matt had some off time and trying to figure out the history here if there was a good reason...

> Thanks for starting the work on the tests! ;) 🙈 I was having trouble even building the solution, but got that to work yesterday. I can have a look...

Yeah, you can do anything you want in _your_ code. To work around this I made a small service like so: ```csharp public class IosEmailService : IEmailService { public Task...

> Hi @Cheesebaron , could you show us what's on your `Email.ComposeAsync(message)` on line 6 of your code above? Who is that `Email`class? That is just MAUI Essentials

I was thinking of adopting the navigation graph and what it provides, but i haven't used it extensively so don't have much experience apart from some simple navigation. These were...

This is because when using PackageReference, generated files for NuGet packages live somewhere in the obj folder for each project. But yeah, there could be an option to nuke +...

> Indeed. In the meantime you can use following approach to use the official scanner: [#96 (comment)](https://github.com/cake-contrib/Cake.Sonar/issues/96#issuecomment-779401679). Neat

For `ConfigureAwait(false)` you write: > ConfigureAwait(false) must be indicated in all asynchronous files That is not correct. It is needed in cases where you are _not_ interested in returning to...