LegacyBar icon indicating copy to clipboard operation
LegacyBar copied to clipboard

Published 20 hours ago • verified publisher icon Cheesebaron

Clean up MenuItemLegacyBarAction

Open Cheesebaron opened this issue 11 years ago • 5 comments

MenuItemLegacyBarAction has both Context and Activity as arguments, is it really necessary?

Cheesebaron avatar Apr 02 '13 19:04 Cheesebaron

Most likely not, I think just activity, whichever i use.

jamesmontemagno avatar Apr 02 '13 20:04 jamesmontemagno

See my latest commit: https://github.com/jamesmontemagno/MonoDroid.ActionBar/commit/79932354f0ac0c4b60d295dff33e98469c7ef1a1

I don't really 100% love how I implemented the "MenuItem" originally, perhaps I need to re-imagine it.....

jamesmontemagno avatar Apr 02 '13 22:04 jamesmontemagno

What we could do is like ActionBar Sherlock does it. They provide their own MenuItem and their own inflater for it.

Cheesebaron avatar Apr 16 '13 17:04 Cheesebaron

I believe this is all fixed up basically now, i think it is fine.

jamesmontemagno avatar Apr 22 '13 21:04 jamesmontemagno

My biggest gripe is, when changing the library to API 14, we will need to implement a bunch of stuff in our MenuItem implementation which is API 14 only, which we don't even use, and have to wrap that in #ANDROID_14 pre-compiler tags, which is suuuuper ugly, and VS thinks there is an error. Will have a look at it this weekend though, I might come up with a nice solution.

Cheesebaron avatar Apr 22 '13 21:04 Cheesebaron