Feature support Valkey
General information
Because of a former license change some linux distributions migrate from redis to its fork valkey (e.g. SLES 15 SP7 does not contain redis anymore. It was replaced with valkey). Same as the MySQL plugin also supports its fork MariaDB the redis plugin should support Valkey. mk_redis already works with Valkey if configured explicitly and either redis-cli is present or is a symlink to valkey-cli.
Proposed changes
Use the mk_redis plugin to detect valkey-server instances and auto-detect the available cli.
This requires two modifications:
- detect running instances with binaries named valkey-server
- make use of the valkey-cli if available
As a bonus this PR moves the special case for the redis-cli of a CheckMK site also into the redis_args function. So configuration of REDIS_CLI_COMMAND is all in one place.
Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days. Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.
This pull request will be closed due to inactivity after 60 days, if no action is taken.
At dev, I would consider creating a dedicated valkey plug-in:
- Eventually users will forget the relation valkey = fork of redis. So they will be looking for valkey, not redis
- Changes in valkey will impact the redis agent plug-in visa versa (example: https://github.com/Checkmk/checkmk/commit/7ed50594ff668c7901a54a589ba47bb83d1cf9d2)
- Makes automated testing more difficult
Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days. Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.
This pull request will be closed due to inactivity after 60 days, if no action is taken.