checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Add SNMP OID to support IBM 4500 tape library

Open schorschii opened this issue 1 year ago • 9 comments

This change adds an additional OID to get more information from IBM 4500 tape libraries via SNMP.

Special thanks to @Yogibaer75 !

schorschii avatar Oct 02 '24 15:10 schorschii

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Oct 02 '24 15:10 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

schorschii avatar Oct 02 '24 15:10 schorschii

recheck

schorschii avatar Oct 02 '24 15:10 schorschii

Oh the format check found a "problem" 😉

-from cmk.agent_based.v2 import SNMPTree, startswith, any_of
+from cmk.agent_based.v2 import any_of, SNMPTree, startswith

Yogibaer75 avatar Oct 03 '24 09:10 Yogibaer75

This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.

github-actions[bot] avatar Oct 25 '24 01:10 github-actions[bot]

@englertor This problem with internal errors inside the workflows should not lead to stale/closed PRs

Yogibaer75 avatar Oct 25 '24 06:10 Yogibaer75

@Yogibaer75 True. I'll forward it and track the PR manually to avoid it going stale.

englertor avatar Oct 25 '24 07:10 englertor

Hi @schorschii @Yogibaer75 ,

We've had some issues in the definition of our upstream pipeline regarding gcc-13. Those are fixed now. Please be so kind to rebase your PR on our latest master and the tests should pass fine afterwards.

Sorry about the inconvenience.

Best Torsten

englertor avatar Oct 25 '24 10:10 englertor

@schorschii thanks for the rebase. It seems there is another issue though :-/. Apologies.

We are on it.

englertor avatar Oct 25 '24 13:10 englertor

@schorschii @Yogibaer75

Meanwhile, we have fixed the other failures well. I've added the PR to our internal tracking.

There is nothing left to do from your side.

Best Torsten

englertor avatar Oct 28 '24 13:10 englertor

Hi @schorschii and @Yogibaer75 thank you for your contribution! :)

You can find the details of your change in the following werk.

logan-connolly avatar Dec 04 '24 15:12 logan-connolly