checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Add linux plugin for nvidia-smi based checks

Open mayrstefan opened this issue 1 year ago • 3 comments

General information

Adds a check plugin for nvidia-smi for linux

Proposed changes

nvidia-smi on linux outputs the same information on linux. So the existing check for windows can be reused for linux. It is only necessary to add a plugin which outputs the same information. This PR adds the plugin for linux. My first attempts to add this to the agent were rejected (#680, #722)

I've also added a simple test which I wrote blind. If it does not work I need some guidance how to run those tests locally

mayrstefan avatar Sep 24 '24 18:09 mayrstefan

This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.

github-actions[bot] avatar Oct 09 '24 02:10 github-actions[bot]

Hi @mayrstefan ,

thank you for your contribution! Unfortunately, we've had some issues in the definition of our upstream pipeline regarding gcc-13. Please be so kind to rebase your PR on our latest master and the tests should pass fine afterwards.

Best Torsten

englertor avatar Oct 25 '24 10:10 englertor

The test are still failing. This time the i18n tests fail

mayrstefan avatar Oct 25 '24 19:10 mayrstefan

You are right. We're on it.

englertor avatar Oct 28 '24 07:10 englertor

Hi @mayrstefan,

We have fixed the tests. I have manually added your PR to our internal tracking (see label tracked).

There is nothing left on your side to do since the test failures were due to our system and not your changes.

Best Torsten

englertor avatar Oct 28 '24 13:10 englertor