checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Changed pathes to FreeBSD layout

Open felixjogris opened this issue 1 year ago • 3 comments

General information

This aligns check_mk_agent with the filesystem hierarchy found on FreeBSD.

Proposed changes

On FreeBSD, check_mk_agent is not part of the base system, but installed via ports or (pre-compiled) packages. Configuration files for these 3rd party applications are expected in /usr/local/etc. Also, FreeBSD has no /var/lib, but /var/db.

felixjogris avatar Aug 08 '24 20:08 felixjogris

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Aug 08 '24 20:08 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

felixjogris avatar Aug 08 '24 20:08 felixjogris

recheck

felixjogris avatar Aug 08 '24 21:08 felixjogris

Hi @felixjogris, thanks a lot for your contribution.

As accepting your change would probably come with some migration effort, could you please explain what makes these changes necessary? Does it lead to concrete problems with your monitoring? Or is it only about complying to standards?

Many thanks in advance!

NikCheckmk avatar May 14 '25 09:05 NikCheckmk

Hi @NikCheckmk ,

solely to comply with the FreeBSD filesystem hierarchy. Please see https://docs.freebsd.org/en/books/handbook/basics/#dirstructure or https://man.freebsd.org/cgi/man.cgi?query=hier&sektion=7:

  • /usr/local: "local executables, libraries, etc, installed by pkg(7) or ports(7)"
  • /var/lib: "state information for ported Linux applications"

One might argue about /var/lib but I believe that a monitoring agent shouldn't count as "ported application". Ports on FreeBSD already patch this (please see https://github.com/freebsd/freebsd-ports/blob/main/net-mgmt/check_mk_agent/Makefile#L56). Thus, I expect no impact for users, just a small change for the ports/package maintainer.

Best regards, Felix

felixjogris avatar May 14 '25 17:05 felixjogris