checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

adds check_metrics for two DRBD checks

Open gurubert opened this issue 1 year ago • 1 comments

both collect the metrics in KiB/s

The resulting graphs were not very pretty.

gurubert avatar Jun 21 '24 09:06 gurubert

Hi Robert! I think we should rather fix the plugin (to produce nice metrics) and then add the translation in the other direction to provide some backwards compatibility.

mo-ki avatar Sep 11 '24 10:09 mo-ki

Hi @gurubert, thank you for bringing this to our attention! I investigated this topic and found the following things:

  1. one of my colleagues took care of adding translations to drbd net and drbd disk back in August so a change to the translations isn't needed at the moment.
  2. the scaling for both these metrics didn't match kb as the unit of measure. So in this change we are now using the appropriate render functions for the scaled metrics.

FYI: we also went ahead and migrated the drbd plugins from legacy to v2. This explains the changed code and file paths.

Closing this since the translations were indirectly picked up in August. The graphs should be more clear in the upcoming 2.4 release. If we missed the mark, feel free to reach out again. Thanks again for your contribution! :)

logan-connolly avatar Dec 06 '24 08:12 logan-connolly