Implement service state filter for quicksearch widget
General information
I use the quicksearch sidebar widget a lot and I often find myself wanting to see all services matching a description that are not OK - so I thought it would be nice to have an additional filter so that I can query for e.g. s:Certificate st:1 st:2.
Proposed changes
I implemented a ServiceStateMatchPlugin class to accomplish this - it works quite well now!
Open tasks/questions:
- What is the first element of the return value of
get_matchessupposed to be? - How to correctly display the "preselected" quicksearch filters in the graphical filter selection dialog?
(See previous PR at #587)
This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.
@github-actions
and the Github Actions are not passing.
Well but that is not my fault, because they are broken in master, too...
This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.
Ping!
I'm at #cmkconf11 if someone wants to talk about this! 😉
I'm going to test your patch this morning. But from a first glance, this looks like a really great addition! Also, super tidy PR 🙌
If you want to chat, please come by the plugin playground stand during the first coffee break session. I'd be happy to chat.
@moschlar thank you again for the awesome feature! Searching on service state will be supported in the next 2.4 release. For more details, have a look at the associated werk: https://checkmk.com/werk/18117