checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Implement service state filter for quicksearch widget

Open moschlar opened this issue 1 year ago • 3 comments

General information

I use the quicksearch sidebar widget a lot and I often find myself wanting to see all services matching a description that are not OK - so I thought it would be nice to have an additional filter so that I can query for e.g. s:Certificate st:1 st:2.

Proposed changes

I implemented a ServiceStateMatchPlugin class to accomplish this - it works quite well now!

Open tasks/questions:

  • What is the first element of the return value of get_matches supposed to be?
  • How to correctly display the "preselected" quicksearch filters in the graphical filter selection dialog?

(See previous PR at #587)

moschlar avatar Jun 20 '24 07:06 moschlar

This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.

github-actions[bot] avatar Jul 05 '24 01:07 github-actions[bot]

@github-actions

and the Github Actions are not passing.

Well but that is not my fault, because they are broken in master, too...

moschlar avatar Jul 05 '24 07:07 moschlar

This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.

github-actions[bot] avatar Jul 20 '24 01:07 github-actions[bot]

Ping!

I'm at #cmkconf11 if someone wants to talk about this! 😉

moschlar avatar May 20 '25 08:05 moschlar

I'm going to test your patch this morning. But from a first glance, this looks like a really great addition! Also, super tidy PR 🙌

If you want to chat, please come by the plugin playground stand during the first coffee break session. I'd be happy to chat.

logan-connolly avatar May 21 '25 05:05 logan-connolly

@moschlar thank you again for the awesome feature! Searching on service state will be supported in the next 2.4 release. For more details, have a look at the associated werk: https://checkmk.com/werk/18117

logan-connolly avatar May 26 '25 09:05 logan-connolly