checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

mk_mysql: Try to find mysql client binary path if it is not in $PATH …

Open t-nitsche opened this issue 3 years ago • 2 comments

…already

Thank you for your interest in contributing to Checkmk! Unfortunately, due to our current work load, we only consider pure bug fixes as stated in our Readme. This means any new pull request that is not a pure bug fix will be closed. Instead of creating a PR, please consider sharing new check plugins, agent plugins, special agents or notification plugins via the Checkmk Exchange.

General information

Please give a brief summary of the affected device, software or appliance. Keep in mind that we are experts in monitoring, but we cannot be experts on all supported devices. A little context will help us assess your proposed change.

Bug reports

Please include:

  • Your operating system name and version
  • Any details about your local setup that might be helpful in troubleshooting
  • Detailed steps to reproduce the bug
  • An agent output or SNMP walk
  • The ID of a submitted crash report for reference (if applicable)

Proposed changes

Sometimes it is hard for us to assess the quality of a fix. While it may work for you, it is our job to ensure that it works for everybody. These are some ways to help us:

  • What is the expected behavior?
  • What is the observed behavior?
  • If it's not obvious from the above: In what way does your patch change the current behavior?
  • Consider writing a unit test that would have failed without your fix.
  • Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?

t-nitsche avatar Oct 21 '22 13:10 t-nitsche

Hello, I need to close the old pull request (https://github.com/tribe29/checkmk/pull/259) and create a new one for this mk_mysql plugin enhancement/bug fix.

t-nitsche avatar Oct 21 '22 13:10 t-nitsche

Thanks. This looks much better. We will merge this shortly.

kain88-de avatar Nov 07 '22 20:11 kain88-de

Dear Checkmk Contributor! Unfortunately, we had to re-write our git-repo history, rendering your PR auto-closed. We will therefore rebase your PR onto the current master and reopen it again. Sorry for the inconvenience.

TimotheusBachinger avatar Jun 19 '24 08:06 TimotheusBachinger

Dear Contributor. Unfortunately, we learned that re-opening a PR which was force-rebased, is not possible (see https://github.com/isaacs/github/issues/361). Therefore we kindly ask you to create a new PR for your change. We apologize for the circumstances and will implement technical measures to prevent such incidents in the future.

TimotheusBachinger avatar Jun 19 '24 13:06 TimotheusBachinger