checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

mk_mysql plugin enhancement

Open t-nitsche opened this issue 5 years ago • 8 comments

Enhancements: 1.) Do not fail but output nothing if we do not have a slave or do not have the required permission. 2.) If mysqladmin is not retrievable via PATH try to receive mysql home from mysqld process.

t-nitsche avatar Oct 05 '20 20:10 t-nitsche

Hi t-nitsche, thank you for this PR, it is queued for internal review. Please not that this will take a while, since we are currently very busy with preparing the release of Checkmk 2.0.0i1. Internal reference: CMK-5753 Best Jörg

jherbel avatar Oct 06 '20 06:10 jherbel

Hi checkmk Team, is there a new status for CMK-5753 available? Best regards Thomas

t-nitsche avatar May 18 '21 07:05 t-nitsche

Hi checkmk Team, is there a new status for CMK-5753 available? Best regards Thomas

t-nitsche avatar Aug 11 '21 07:08 t-nitsche

Hi Thomas,

Since this has been without any activity for a while now, I'll mark this as 'Stale'. Currently this means that without any update, this will auto-close in 3 weeks time.

If this happens but you want to continue to work on this, you are of course invited to open a new PR (ideally with the requested changes addressed). This helps us focusing on the active PRs, such that we can continue to work on our response time.

I hope you understand!

Cheers, Moritz

mo-ki avatar Jul 29 '22 12:07 mo-ki

I'll close this now due to inactivity. See the remark above :-)

mo-ki avatar Sep 06 '22 09:09 mo-ki

Hi Moritz,

 

sorry for being in holiday but hopefully not missing the 3 weeks auto close timer.

 

I'm fine if you add some well known directorys where mysql installation normaly will be placed to the path environment variable instead.

 

Best regards,

Thomas  

Gesendet: Freitag, 29. Juli 2022 um 14:02 Uhr Von: "Moritz" @.> An: "tribe29/checkmk" @.> Cc: "t-nitsche" @.>, "Author" @.> Betreff: Re: [tribe29/checkmk] mk_mysql plugin enhancement (#259)

 

Hi Thomas,

Since this has been without any activity for a while now, I'll mark this as 'Stale'. Currently this means that without any update, this will auto-close in 3 weeks time.

If this happens but you want to continue to work on this, you are of course invited to open a new PR (ideally with the requested changes addressed). This helps us focusing on the active PRs, such that we can continue to work on our response time.

I hope you understand!

Cheers, Moritz

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

t-nitsche avatar Oct 11 '22 07:10 t-nitsche

Hi Thomas

Can you add the hard coded paths and update the pull request. I can re-open it once you make push a change.

kain88-de avatar Oct 11 '22 15:10 kain88-de

Hi Max,

I though the Tribe29 developers would add the hard coded paths. But then the pull request has been closed. If you can open it again I'll try my best to collect some of the common mysql installation directories and add them to this pull request.

Best regards Thomas

t-nitsche avatar Oct 12 '22 20:10 t-nitsche

For some reasons I closed this pull request and opened a new one https://github.com/tribe29/checkmk/pull/524. Hope this is ok for you.

t-nitsche avatar Oct 21 '22 14:10 t-nitsche

no worries that is no problem. I'm off next week and have time to look ove the new PR in november.

kain88-de avatar Oct 21 '22 21:10 kain88-de