kics icon indicating copy to clipboard operation
kics copied to clipboard

fix(query): fp for ECS Cluster with Container Insights Disabled -- cloudformation/aws

Open AndrePereira123 opened this issue 5 months ago • 1 comments

Closes #7338

Reason for Proposed Changes

  • As disclosed in 7338, currently the query wrongfully flags instances of "ClusterSettings"`s value being set to "enhanced".
  • "enhanced" is supported by official documentation which explicitly states this value is "To use Container Insights with enhanced observability"

Proposed Changes

  • Simple expansion to the "container_insigths" helper function.
  • New negative3 test to assure "enhanced" value does not flag.

I submit this contribution under the Apache-2.0 license.

AndrePereira123 avatar Jul 22 '25 22:07 AndrePereira123

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
20838717 Triggered Generic Password 3f5bfc5fcbb714aef58b31a66843a4a2bc047418 assets/queries/azureResourceManager/sql_server_database_with_alerts_disabled/test/negative8.bicep View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Sep 22 '25 09:09 gitguardian[bot]