kics icon indicating copy to clipboard operation
kics copied to clipboard
verified publisher icon Checkmarx

feat(kics): add usage of parallel flag for analyzer

Open cx-marco-pereira opened this issue 1 year ago • 2 comments

Closes #6934

Proposed Changes

  • Use the already added parallel flag to set the number of workers on the analyze portion of the scan command
  • Use the already added parallel flag to set the number of workers on the analyze standalone command
  • Add unit test for flag adjust value utils func

I submit this contribution under the Apache-2.0 license.

cx-marco-pereira avatar Mar 07 '24 12:03 cx-marco-pereira

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

github-actions[bot] avatar Mar 07 '24 12:03 github-actions[bot]

Hi, thanks a bunch for this contribution! Should help solve my issue (https://github.com/Checkmarx/kics/issues/6934).

I have a quick question that maybe I'm misunderstanding: This solution uses the same amount of parallel workers for both scan and analyze when running kics scan, correct? So the behavior is the following - setting X parallel workers in the scan flags will scan using X * platforms workers, while the analyze section will only run X parallel workers. Hypothetically, if KICS supported 100 platforms and one wants a maximum of 100 concurrent workers, one would set the parallel flag to 1 and then analyze would run with a single worker (and unavoidably so).

Is this the intended behavior?

nierz avatar Mar 10 '24 09:03 nierz