kics-github-action icon indicating copy to clipboard operation
kics-github-action copied to clipboard

Error finding results when output-name specified

Open lewis-shell opened this issue 1 year ago • 3 comments

When the output-name parameter is set to anything other than "results" (e.g. using a config file), the action still looks for a file called results.json, which then causes an error to be logged in the console

To reproduce

kics-config.json:

{
  "output-name": "my-results"
}

Workflow file:

      - name: "Scan with KICS"
        uses: checkmarx/[email protected]
        with:
          path: "."
          config_path: kics-config.json
          platform_type: terraform
          output_path: kics-results
          output_formats: "json,sarif"

Error message:

Running KICS action...
Error: ENOENT: no such file or directory, open 'kics-results/results.json'
    at Object.openSync (node:fs:603:3)
    at Object.readFileSync (node:fs:471:35)
    at readJSON (/app/dist/index.js:16785:24)
    at main (/app/dist/index.js:16854:31)
    at /app/dist/index.js:16872:1
    at /app/dist/index.js:16874:3
    at Object.<anonymous> (/app/dist/index.js:16877:12)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: 'kics-results/results.json'
}

lewis-shell avatar Aug 14 '23 08:08 lewis-shell

Adding the code reference which has results.json hardcoded since the github action doesn't read output-name variable. https://github.com/Checkmarx/kics-github-action/blob/6d02dc9f4e53edc55885e61eb7e938537422c427/src/main.js#L21

kaplanlior avatar Aug 14 '23 08:08 kaplanlior

Im having the same issue - have you found a solution?

toestreich avatar Sep 19 '23 17:09 toestreich

Hi @toestreich and @lewis-shell, I am glad to let you know that this issue is being addressed on the #106. Now the KICS GitHub action will take into account the output name set on the config file.

cxMiguelSilva avatar Mar 12 '24 14:03 cxMiguelSilva