ast-cli icon indicating copy to clipboard operation
ast-cli copied to clipboard

Make containers scan by default on cloud (AST-84506)

Open cx-alex-cohen opened this issue 10 months ago • 2 comments

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • [ ] I have added documentation for new/changed functionality in this PR (if applicable).
  • [ ] I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • [ ] All active GitHub checks for tests, formatting, and security are passing
  • [ ] The correct base branch is being used

cx-alex-cohen avatar Jan 30 '25 21:01 cx-alex-cohen

Logo Checkmarx One – Scan Summary & Details979cf838-cb71-4ec9-9f98-5391e9a32a98

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar Jan 30 '25 21:01 github-actions[bot]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15671991 Triggered Generic High Entropy Secret 89dbaefc2483ffdee7ce9388393883d3929b3ea4 internal/wrappers/client_test.go View secret
17327706 Triggered JSON Web Token 7fc1be7e23e5edf907a4d29f62d5f33b4e317916 test/integration/scan_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Feb 25 '25 14:02 gitguardian[bot]