Chavda Sachin

Results 43 comments of Chavda Sachin

@Julesssss I haven't raised PR here yet, coz I am testing other scenarios where we might need same implementation. Like - copilot is able to close owner's account. So let...

Will send you a list in a couple hrs, and after your confirmation will raise PR.

hey @Julesssss could you take a look at the list below, I guess most of them should have the restriction for copilots. Few already has restrictions implemented from BE. Actions...

TryNewDot might be part of hybrid app, right? I don't have access to hybrid app yet, do you think you could add me?

For our last PR, we used `shouldBeBlocked` with `AccessOrNotFoundWrapper` here. https://github.com/Expensify/App/blob/df3e1e435cf2fe1f4b731a4cbaadd598f40d0085/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx#L121 But since here we need to make use of it many times , as a general solution do you...

The new wrapper makes more sense to me rather than using fullPageNotFound.

PR is nearly 80% done, but since it would be large PR - I am spending more time on testing and am focusing on making more scalable changes. Should be...

Edited by **proposal-police**: This proposal was **edited** at 2024-08-30 20:43:57 UTC. ## Proposal ### Please re-state the problem that we are trying to solve in this issue. Editing quote markdown...

[updated proposal](https://github.com/Expensify/App/issues/47951#issuecomment-2308868522), added alternative solution which looks more sensible to me

@fedirjh It looks like two blockquotes must be separated by space is recommended design feature. So, we might need a design review on this one. check https://github.com/Expensify/App/issues/45154#issuecomment-2222162593 .