chatterino2 icon indicating copy to clipboard operation
chatterino2 copied to clipboard

Published 20 hours ago • verified publisher icon Chatterino

Add Helix announce endpoint

Open Mm2PL opened this issue 2 years ago • 1 comments

Pull request checklist:

  • [ ] CHANGELOG.md was updated, if applicable

Description

Mm2PL avatar Sep 19 '22 15:09 Mm2PL

Idk if it is important, but shouldn't Helix::sendChatAnnoucement rather be Helix::sendChatAnnouncement (missing n in Announcement)

Wissididom avatar Sep 21 '22 09:09 Wissididom

Can we implement colored announcements in this PR (maybe just the commands)? I believe the only real disdain against them was the fact that IRC invoked announcements did not return color data, which is "resolved" by their deprecation.

Felanbird avatar Sep 24 '22 12:09 Felanbird

Idk if it is important, but shouldn't Helix::sendChatAnnoucement rather be Helix::sendChatAnnouncement (missing n in Announcement)

fixed

Mm2PL avatar Sep 24 '22 12:09 Mm2PL

Can we implement colored announcements in this PR (maybe just the commands)? I believe the only real disdain against them was the fact that IRC invoked announcements did not return color data, which is "resolved" by their deprecation.

I decided to introduce internal support for sending colored announcements as it was simply more effort to not do it. I didn't want to do commands because I wanted the PR to only move the existing command to helix, just fix the 'bug' and not introduce any new features at the same time. :)

Mm2PL avatar Sep 24 '22 12:09 Mm2PL

ibana.pjg

Mm2PL avatar Sep 24 '22 15:09 Mm2PL