chatterino2 icon indicating copy to clipboard operation
chatterino2 copied to clipboard

/live not working

Open Nerxxy opened this issue 2 years ago • 17 comments

Checklist

  • [X] I'm reporting a problem with Chatterino
  • [X] I've verified that I'm running the most recent nightly build or stable release
  • [X] I've looked for my problem on the wiki
  • [X] I've searched the issues and pull requests for similar looking reports

Describe your issue

I have a lot of channels in the Live Notification setting and I know at least one of the channels in there are currently live but I didn't get a notification.

Screenshots

live2 I'm not entirely sure if the "------------" channels have broken anything? I put them there as sub categories, they are not really need just thought it would be a nice addition.

image As you can see in the first image there is a channel called "BigPurpin" and in this image you can see that hes live and not showing in the /Live tab.

OS and Chatterino Version

Chatterino Nightly 2.3.5 (commit 683701623 modified) built on with Qt 5.15.2, Windows SDK, MSVC 193231329 Running on Windows 10 Version 2009, kernel: 10.0.19044

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

Try re-logging into Chatterino, your oauth probably expired which is causing helix calls to fail. image

Felanbird avatar Jul 23 '22 01:07 Felanbird

Try re-logging into Chatterino, your oauth probably expired which is causing helix calls to fail. image

I have tried that already.

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

Lemme see if its because of the "--------" channels

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

its because of the "----------" channels....

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

If it is you can just rename the tab nickname instead of attempting to connect to that non-existent channel.

Felanbird avatar Jul 23 '22 01:07 Felanbird

I just removed all of the ----- channels and restarted chatterino and got a notif for bigpurpin

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

image

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

I guess the --------- channels are throwing some sort of error?

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

just tried with ______ instead and still didnt get a notif

Nerxxy avatar Jul 23 '22 01:07 Nerxxy

Helix returns an error if one of the nicknames is malformed iirc. This is probably why. I suggest you just remove these channels from your list.

23 lip 2022 03:27:26 Nerxxy @.***>:

just tried with ______ instead and still didnt get a notif

— Reply to this email directly, view it on GitHub[https://github.com/Chatterino/chatterino2/issues/3873#issuecomment-1193032016], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AF62MIXQ4IGBR5OOKTRSKJ3VVNC7LANCNFSM54NFA2QQ]. You are receiving this because you are subscribed to this thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADkAAAA5CAYAAACMGIOFAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAkSURBVGiB7cExAQAAAMKg9U9tDQ+gAAAAAAAAAAAAAAAA4NQAMv0AAa3l6BAAAAAASUVORK5CYII=###24x24:true###][Obrazek śledzący][https://github.com/notifications/beacon/AF62MISY3QSW2NIXW7G6P23VVNC7LA5CNFSM54NFA2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI4ODSUA.gif]Message ID: @.***>

Mm2PL avatar Jul 23 '22 08:07 Mm2PL

Is there any symbol that doesn't throw back an error?

The "sub category channels" aren't really needed, just nice to have imo.

Nerxxy avatar Jul 23 '22 23:07 Nerxxy

Is there any symbol that doesn't throw back an error?

We don't use c++ exceptions for non-200 error codes. Look at the logs it should show an error probably a 400 every so often fetching these channels by name.

Mm2PL avatar Jul 24 '22 00:07 Mm2PL

We don't use c++ exceptions for non-200 error codes. Look at the logs it should show an error probably a 400 every so often fetching these channels by name.

I wouldn't even know how to see the logs.

Another thing I found, is that say these are my live notification channels:

  • xqc
  • summit1g
  • halo
  • zooma
  • ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ ‎ friends
  • helixladder
  • bigpurpin
  • spiccytacos

I would get notifications from the bottom 3 but not the top 4

Nerxxy avatar Jul 24 '22 00:07 Nerxxy

I would get notifications from the bottom 3 but not the top 4

This should be happening because you have the bottom 3 channels open, but not the top 4, so the fallback of checking the channels you actually have open is covering the live notification. If you added summit1g's chat to Chatterino his /live notif would work, or if you removed bigpurpin's chat you would lose his notif.

Felanbird avatar Jul 24 '22 03:07 Felanbird

just tried with ______ instead and still didnt get a notif

How did you test it with _____ if you are on https://github.com/Chatterino/chatterino2/commit/683701623a0c6f86b27f25f50bb46a2bf2bd64cc? You should be forbidden from entering that character combination due to the changes implemented in 07dd8c560bcb73d0e1a76bf330771624cca82f47

Felanbird avatar Jul 24 '22 03:07 Felanbird

Either way, If you want to continue to using live notifications in this way, you'll have to build your placeholder channels to respect Twitch's naming structure.

  • no special characters at position 0 usernames cannot start with _
  • following, only 0-9 A-Z a-z and _

For example, FRIENDS______ should be a valid live notification, but obviously if that user ever goes live you'll get a notif, but that seems unlikely.

Felanbird avatar Jul 24 '22 04:07 Felanbird

How did you test it with _____ if you are on 6837016? You should be forbidden from entering that character combination due to the changes implemented in 07dd8c5

I just put the underscores in...

image

I have removed all the sub category channels now. Ty for the help guys.

Nerxxy avatar Jul 24 '22 16:07 Nerxxy

Since #3715 it is impossible to type an invalid username into the list.

Prevent user from entering incorrect characters in Live Notifications channels list (#3715)

This should no longer happen.

Mm2PL avatar Aug 04 '23 11:08 Mm2PL