chatterino2
chatterino2 copied to clipboard
Added notes to usercards
Pull request checklist:
- [x]
CHANGELOG.md
was updated, if applicable
Description
Allows users to set notes for other people. The note is stored alongside the user's ID so a username change wont affect them. All clientside and doesn't have to do with mod comments. Works kind of like the discord notes. would close #2413
Functionality is all there, just need to make the UI look better
Example:
https://user-images.githubusercontent.com/35087590/168693634-fdd9c20d-a54a-4eee-b8ab-9f2067b0eb3c.mp4
early suggestions:
- current UI in demo is imo way too prominent for this feature. What about adding "Note:" row above Views, limited to single row of text and expandable to full length at click. Preferably edited inline after pressing some small pen icon ✏️ button.
- store user notes in own file
I would make the place for the notes a lot smaller because now its j8ust too big in my opinion
Wanted to get something down first. Didn't know how the UI should be when making this PR. I'll work on kornes' suggestions later today/tomorrow
I'm wondering if a better approach is displaying the note, and using a small edit button to bring up a prompt to set the note. It seems very correct to just have a seperate window for setting the note.
similar to the PR adding a reply window
using a small edit button to bring up a prompt to set the note
I'd dislike having a popup window spawning a popup window. I feel like that might get confusing.
But a green or blue paint on the bikeshed doesn't really matter when there is no bikeshed built yet.
- [ ] Use a separate file for this rather than saving it in
settings.json
- [ ] Improve UI (see Discord for inspiration)
- [ ] Make sure newly created notes.json have backups automatically generated
Lost interest in this, if anyone wants to pick this up go ahead.