chatterino2
chatterino2 copied to clipboard
Chatterino
add "show live tabs only" option
Pull request checklist:
- [ ]
CHANGELOG.mdwas updated, if applicable
Description
This PR adds a "show live tabs only" option that hides tabs which are not marked as live. By default, it is disabled and has no hotkey bound to it. While active, it locks the tab layout, since it's not clear how a change in layout should translate when offline tabs are unhidden. When tabs are marked as live/not live, they will automatically be inserted/hidden appropriately.
A video demonstration of the core functionality can be found here.
I'd appreciate your feedback. Thank you.
Super interesting feature! Would love to get this merged in. Haven't had a time to review the actual code yet but thank you for working on it!
I've addressed both bugs in this last set of changes.
CTRL+(SHIFT)+Tab will now cycle through only the displayed tabs, and the channel switcher will now correctly focus offline tabs. Would it be better for the channel switcher filter out offline tabs instead?
I've noticed that I can't change the channel of a split while the setting is enabled. I'll look into fixing that.
I don't like the idea this "feature" brings, wouldn't this clash with "toggle visibility of tabs"? shouldn't rather already existing tab visibility 0(hidden)/1(visible) be changed to something like an enum? e.g. 0/1/2 - hidden, all visible, only live visible, etc... if someone decides to add more things and maintain better future-compatibility.
Agree with @zneix on this one, combining the two similar features into a single setting would make this a whole lot nicer to work with in the future - should we need to add something else around tab visibility.
Will I stay in the chat of the offline streamer as well or will it automatically leave these and only stay inside the live streamer?
Will I stay in the chat of the offline streamer as well or will it automatically leave these and only stay inside the live streamer?
Toggling this setting yields a strictly visual change. You will stay connected to offline chat rooms in the background, only their tabs will not be shown in the notebook.
