chatterino2 icon indicating copy to clipboard operation
chatterino2 copied to clipboard

Link Preview too small ๐Ÿœ

Open Felanbird opened this issue 3 years ago โ€ข 5 comments

Discussed in https://github.com/Chatterino/chatterino2/discussions/3462

Originally posted by romeogiggletoes January 3, 2022

Checklist

  • [X] I'm reporting a problem with Chatterino
  • [X] I've verified that I'm running the most recent nightly build or stable release
  • [X] I've looked for my problem on the wiki
  • [X] I've searched the issues and pull requests for similar looking reports

Describe your issue

I find that the previews are very hard to read with it being so small. Sometimes the preview is slightly bigger than others, but for example the runescape screenshots caught by Scriptorex are way too small. No matter how close I get to my screen I cannot (LUL) make out what is suppose to be portrayed. My display might just be bugged though I can send a screen shot of it

It seems like the first link preview in #1664 was a little bit bigger, but still not big enough.

Screenshots

chatterino link preview issue

No response

OS and Chatterino Version

Chatterino Nightly + Dankerino patches 2.3.4 (commit 3044f4a5d, ) on Windows 10

Felanbird avatar Jan 06 '22 07:01 Felanbird

Moving this comment from the earlier discussion

Possible fix: Modify the 'large' option for link previews to be bigger or alternatively make an extra large option. I have shown below how big I thing it should be.

Chatterino Link Preview

Edit: With some help from Karar I learned that you can put in pixels how large you want the preview, however it's way too blurry to be useful. What I was more so referring to was to make the preview bigger while keeping the same image quality. As a side note, I do like that there can be custom values for this and not just the default presets, however as previously stated, anything larger than the 'Large' preset isn't really usable.

2022-01-05 14_29_31-Chatterino Settings 2022-01-05 14_30_15-Link Preview for ants ๐Ÿœ ยท Discussion #3462 ยท Chatterino_chatterino2 โ€” Mozilla F

romeogiggletoes avatar Jan 06 '22 07:01 romeogiggletoes

I looked into this a bit. The thumbnail that comes back from braize.pajlada.com is already very low res, at least for GitHub thumbnails. Compare https://braize.pajlada.com/chatterino/thumbnail/https%3A%2F%2Fopengraph.githubassets.com%2F562629478fb54c347751dbfe92f9da6a7ecb659f5121ad1e2b2c829ddca533fc%2Frecp%2Fcglm and https://opengraph.githubassets.com/562629478fb54c347751dbfe92f9da6a7ecb659f5121ad1e2b2c829ddca533fc/recp/cglm, for example. I don't know how the braize API works, but we would need to pass a width/height or just get a higher res image by default.

KleberPF avatar Feb 15 '24 01:02 KleberPF

The braize API is this: https://github.com/chatterino/api. The maximum thumbnail size by default is 300 and I believe that instance uses the default config.

Mm2PL avatar Feb 15 '24 01:02 Mm2PL

I see. Is there anything that could be done here then? I don't know if altering the thumbnail max size is feasible.

KleberPF avatar Feb 15 '24 01:02 KleberPF

@pajlada What would be your opinion on upping the thumbnail size for the official Chatterino API instance?

We could also have an option to fetch the thumbnail directly from the client and not proxied through the API (needs to be an explicit opt-in due to the privacy risk), but I don't think it is the best thing to do.

Mm2PL avatar Feb 15 '24 01:02 Mm2PL