chatterino2 icon indicating copy to clipboard operation
chatterino2 copied to clipboard

Emote/user tab completion completes using wrong word

Open jupjohn opened this issue 3 years ago • 3 comments

Describe your issue Tab completion of emotes/usernames can also complete when moving to prior word.

Steps to reproduce

  1. Type a single word
  2. Type another word and tab complete to an emote/user
  3. Press left arrow until you are at the last character of the first word
  4. Press tab again

Expected behaviour Previous word tries to complete using the word

Observed behaviour Previous word thinks it's the second word so tried to complete using those characters

Screenshots https://user-images.githubusercontent.com/4962764/127768320-e14afc52-4b84-4ff3-ab03-c604c6f248e0.mp4

OS and Chatterino Version Arch Linux (N/A), Chatterino 2.3.3 (commit ae9f92de)

This is a hard one to explain (and title), hope the vid does it justice.

jupjohn avatar Aug 01 '21 11:08 jupjohn

Can reproduce on ae9f92de

Mm2PL avatar Aug 01 '21 11:08 Mm2PL

can also reproduce on 3cb1e51

xHeaveny avatar Aug 01 '21 11:08 xHeaveny

I did some investigation and it looks like the completer doesn't respect changing the cursor. This happens as well if the cursor is changed with the mouse or the entire content of the textbox with up-arrow/down-arrow. This issue could probably be solved by adding a check inside of ResizingTextEdit::keyPressEvent for those specific events.

M4tthewDE avatar Aug 23 '21 18:08 M4tthewDE