chatterino2 icon indicating copy to clipboard operation
chatterino2 copied to clipboard

spellcheck for input

Open fourtf opened this issue 8 years ago • 14 comments

fourtf avatar Feb 06 '17 14:02 fourtf

Some form of grammarly integration might make this easier ¯_(ツ)_/¯

ALazyMeme avatar Sep 10 '19 01:09 ALazyMeme

This repo might help https://github.com/manisandro/qtspell but it would be another dependency.

Mm2PL avatar Sep 28 '19 10:09 Mm2PL

Any pogress on this? It's a useufl feature as tyou can tell I can'ttype.

KararTY avatar Jan 30 '20 22:01 KararTY

bump ppBounce

Mm2PL avatar Jun 29 '20 20:06 Mm2PL

bump

pbuckles22 avatar Jun 11 '21 22:06 pbuckles22

No updates.

Mm2PL avatar Jul 24 '21 16:07 Mm2PL

No updates. 24 lip 2021 18:27:36 CycloneTM @.***>: Bump any updates

Does this mean its not possible or are still investigating into it?

PsycloneTM avatar Jul 24 '21 16:07 PsycloneTM

Does this mean its not possible or are still investigating into it?

Look into this yourself if you want this so badly, others are busy with other things or simply don't care.

zneix avatar Jul 24 '21 16:07 zneix

I personally think its best if we wait until we have to ditch QMake until we add another dependency. It's possible but I don't think anyone is working actively working it.

Mm2PL avatar Jul 24 '21 17:07 Mm2PL

As per recent research - there's either hunspell or qtspell we could use but that seems like adding another dependency; even Qt's example for adding spellcheker suggests using hunspell. So, as per mm2pl's above comment this is going to stay as 'blocked' until we get rid of QMake or something changes.

zneix avatar Dec 31 '21 19:12 zneix

I would like to reopen the discussion about this.

QtSpell

Pros:

  • Extremely easy to implement.
  • Automatic dictionary detection
  • Has "add to dictionary" and "ignore"
  • Has misspelled error formatting with QTextEdit

Cons:

  • GPL, How will it affect the project or the artifacts?
  • Dynamic linking is hard on windows, but if we do static linking, and since it uses enchant, we gotta add it as a dependency (and enchant needs glib as a dependency)

Also this needs some dictionary provider to be installed, we need to check how is this achieved on window? (assuming mac is similar to linux)

Hunspell

Pros:

Cons:

  • We need to provide the dictionary path, either let the user enter it or we find a way to detect it.
  • "Add to dictionary" and "ignore" should be done by us, so have a list of words in a text file that are added and are ignored and store it in the configs files.

what do you think?

mohad12211 avatar Jun 15 '23 15:06 mohad12211

For the record, there's also lib_spellcheck from Telegram (which can't be used because of the large dependency graph). It can integrate the system spellchecker. It supports:

Nerixyz avatar Jun 15 '23 16:06 Nerixyz

I lean towards hunspell - licensing & simplicity of using cross-platform. I imagine any of its drawbacks we can get around with some engineering

pajlada avatar Jun 16 '23 08:06 pajlada

I like hunspell. We specifically need to ignore emotes from the spell checker anyway. Delivering dictionaries sucks a little but it seems like an okay trade off to me.

Mm2PL avatar Jul 14 '23 12:07 Mm2PL