chatterino2
chatterino2 copied to clipboard
spellcheck for input
Some form of grammarly integration might make this easier ¯_(ツ)_/¯
This repo might help https://github.com/manisandro/qtspell but it would be another dependency.
Any pogress on this? It's a useufl feature as tyou can tell I can'ttype.
bump ppBounce
bump
No updates.
No updates. 24 lip 2021 18:27:36 CycloneTM @.***>: … Bump any updates
Does this mean its not possible or are still investigating into it?
Does this mean its not possible or are still investigating into it?
Look into this yourself if you want this so badly, others are busy with other things or simply don't care.
I personally think its best if we wait until we have to ditch QMake until we add another dependency. It's possible but I don't think anyone is working actively working it.
As per recent research - there's either hunspell or qtspell we could use but that seems like adding another dependency; even Qt's example for adding spellcheker suggests using hunspell. So, as per mm2pl's above comment this is going to stay as 'blocked' until we get rid of QMake or something changes.
I would like to reopen the discussion about this.
QtSpell
Pros:
- Extremely easy to implement.
- Automatic dictionary detection
- Has "add to dictionary" and "ignore"
- Has misspelled error formatting with QTextEdit
Cons:
- GPL, How will it affect the project or the artifacts?
- Dynamic linking is hard on windows, but if we do static linking, and since it uses enchant, we gotta add it as a dependency (and enchant needs glib as a dependency)
Also this needs some dictionary provider to be installed, we need to check how is this achieved on window? (assuming mac is similar to linux)
Hunspell
Pros:
- can be linked with LGPL, no problems with that AFAIK.
- No extra runtime dependencies
Cons:
- We need to provide the dictionary path, either let the user enter it or we find a way to detect it.
- "Add to dictionary" and "ignore" should be done by us, so have a list of words in a text file that are added and are ignored and store it in the configs files.
what do you think?
For the record, there's also lib_spellcheck
from Telegram (which can't be used because of the large dependency graph). It can integrate the system spellchecker. It supports:
- cld3 for language detection
- hunspell on all platforms
- enchant on Linux
-
Natural Language and
NSSpellChecker
on macOS -
elscore.h
andspellcheck.h
on Windows
I lean towards hunspell - licensing & simplicity of using cross-platform. I imagine any of its drawbacks we can get around with some engineering
I like hunspell. We specifically need to ignore emotes from the spell checker anyway. Delivering dictionaries sucks a little but it seems like an okay trade off to me.